fix(explore): revert dnd column dependency array change to fix infinite rerenders

[kgabryje]

SUMMARY

Revert change in dependency array in DndColumnSelect introduced in #16073 - it causes infinite rerenders and page freeze when interacting with the component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

Approving because it broke the dnd.

We should address the comments in the original PR in a follow-up PR.

[codecov]

Codecov Report

Merging #16115 (189d1df) into master (b80f018) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 189d1df differs from pull request most recent head f825c5f. Consider uploading reports for the commit f825c5f to get more accurate results

@@           Coverage Diff           @@
##           master   #16115   +/-   ##
=======================================
  Coverage   76.84%   76.85%           
=======================================
  Files         995      995           
  Lines       52886    52886           
  Branches     6721     6721           
=======================================
+ Hits        40640    40643    +3     
+ Misses      12021    12018    -3     
  Partials      225      225           

Flag	Coverage Δ
javascript	71.23% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx	46.42% <ø> (ø)
...ols/DndColumnSelectControl/utils/optionSelector.ts	46.15% <0.00%> (+11.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80f018...f825c5f. Read the comment docs.

[rosemarie-chiu]

🏷 2021.31