-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChannelTuple: add ability to call regular callable #4292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this should do :)
0288686
to
3092964
Compare
Codecov Report
@@ Coverage Diff @@
## master #4292 +/- ##
=======================================
Coverage 68.35% 68.36%
=======================================
Files 276 276
Lines 31023 31029 +6
=======================================
+ Hits 21207 21213 +6
Misses 9816 9816 |
3092964
to
43961ce
Compare
18af58c
to
1218ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! :)
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
bors merge |
This IMHO eliminates the only important feature Functions has over a regular method on a InstrumentModule/Channel
TODO