Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with circuit changes #31

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Update with circuit changes #31

merged 5 commits into from
Jul 24, 2023

Conversation

ConstanceBeguier
Copy link

@ConstanceBeguier ConstanceBeguier commented Jul 6, 2023 •
edited

  • Add the new nullifier equation for split notes
  • Add a link to Orchard circuit document
  • Add is_native_asset auxiliary witness
  • Remove constraint (split_flag=1) => (v_old != 0)
  • Add constraint (split_flag=1) => (is_native_asset=0)

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited

✅ Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit cb59ab0
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/64ad2313205807000840b540
😎 Deploy Preview https://deploy-preview-31--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vivek-arte
vivek-arte reviewed Jul 10, 2023
View reviewed changes
Copy link

@vivek-arte vivek-arte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to add undefined terms.

zip-0226.rst Outdated Show resolved Hide resolved
zip-0226.rst Outdated Show resolved Hide resolved
zip-0226.rst Outdated Show resolved Hide resolved
zip-0226.rst Outdated Show resolved Hide resolved
vivek-arte
vivek-arte approved these changes Jul 11, 2023
View reviewed changes
Copy link

@vivek-arte vivek-arte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further changes, thanks! Just added a note for future to switch from the Google Doc to a PDF.

zip-0226.rst Show resolved Hide resolved
@ConstanceBeguier ConstanceBeguier merged commit 4f5e2af into zsa1 Jul 24, 2023
5 checks passed
PaulLaux pushed a commit that referenced this pull request Oct 4, 2023
@ConstanceBeguier @PaulLaux
Update with circuit changes (#31)
5d26401 
- Add the new nullifier equation for split notes
- Add a link to Orchard circuit document
- Add is_native_asset auxiliary witness
- Remove constraint (split_flag=1) => (v_old != 0)
- Add constraint (split_flag=1) => (is_native_asset=0)
vivek-arte pushed a commit that referenced this pull request Feb 12, 2024
@ConstanceBeguier @daira
Update with circuit changes (#31)
e5f03d9 
- Add the new nullifier equation for split notes
- Add a link to Orchard circuit document
- Add is_native_asset auxiliary witness
- Remove constraint (split_flag=1) => (v_old != 0)
- Add constraint (split_flag=1) => (is_native_asset=0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulLaux PaulLaux PaulLaux approved these changes

@vivek-arte vivek-arte vivek-arte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ConstanceBeguier @PaulLaux @vivek-arte