Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming idk to imk throughout ZIP 227 #41

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

vivek-arte
Copy link

This PR does a consistent renaming of the issuance derivation key to call it the issuance master key.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit 0388d5c
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/651bb438fa435600080a420c
😎 Deploy Preview https://deploy-preview-41--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid.

image
Still updated, is this done in the subsequent pr?

@vivek-arte
Copy link
Author

The subsequent PR (#40 )renames the idk in the image to imk and also reduces to a two-key structure instead of three keys.

@vivek-arte vivek-arte merged commit ef406db into zsa1 Oct 3, 2023
4 checks passed
PaulLaux pushed a commit that referenced this pull request Oct 4, 2023
This is a consistent renaming of the issuance derivation key to call it the issuance master key.
vivek-arte added a commit that referenced this pull request Feb 12, 2024
This is a consistent renaming of the issuance derivation key to call it the issuance master key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants