Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"measurementItems" value as a string, DICOM SR tid1500 #406

Open
ForgottenOneNyx opened this issue Aug 19, 2020 · 4 comments
Open

"measurementItems" value as a string, DICOM SR tid1500 #406

ForgottenOneNyx opened this issue Aug 19, 2020 · 4 comments

Comments

@ForgottenOneNyx
Copy link

Hello, I am new to DICOM SRs, and I was wondering if we could somehow write the value in measurementItems as a string.

Considering the example given in sr-tid1500-ct-liver-example.json we can't because the value in measurementItems corresponds to "DS" definition, in common-schema.json. Does it have to remain "DS" to adhere to the DICOM SR rules? Or can it be changed.

If yes, I would like it to be of a different definition which preferably includes long strings. Do you know how I can do that? I am presently using docker to create the DICOM SRs. The idea is to add the measurementItems but as "NaNs" if they don't exists, which can't be done by the "DS" defintion.

@fedorov
Copy link
Member

fedorov commented Aug 19, 2020

@ForgottenOneNyx if a given measurement does not exist, it is definitely not a good idea to add a NaN as a measurement. You should just not add that measurement at all. This means that you cannot use a fixed structure dcmqi metadata JSON file and it will need to be customized depending on what measurements are present, which is more work at the time of generating the object, but it is the correct way to do it, I believe.

It is indeed the case that the numeric value communicating the measurement has DS VR (see definition of Numeric Measurement Macro, and Numeric Value). Yes, it has to remain DS, and, from what I know about the DICOM standard, at that level it cannot be changed.

It is a separate question what to do if the measurement you want to communicate is indeed a NaN. I do not have the answer to this question, but I will investigate.

@fedorov
Copy link
Member

fedorov commented Aug 19, 2020

As clarified by @dclunie (see below), it is possible to communicate that a measurement is a NaN, but this will require new feature to be implemented.

Response from David Clunie:

That's what the Numeric Value Qualifier Code Sequence is for, and there is a dedicated code:

http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_42.html

See also this CP 2023:

ftp://medical.nema.org/medical/dicom/cp/cp2023_02_ClarifyUnknownNumericMeasurementValueInSR.pdf

@jriesmeier
Copy link
Member

@fedorov In case, the DCMTK is used here somewhere: Adding support for CP-2023 is already on my to-do list.

By the way, this CP is a result of a discussion that I had with Stefan Allers in the newsgroup "comp.protocols.dicom".

@jriesmeier
Copy link
Member

Support for CP-2023 has been added to the DCMTK by this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants