-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified driver dmc batched #1947
Conversation
start of DMCBatch testing
This is a good place to stop this PR as the next step is refactoring the branch engine and walker controllers which will be quite involved. |
Can you ("we") defer updating the branch engine and walker controllers or is this required to get DMC batched working and estimate a FOM + throughput vs system size? |
Can't be completely avoided due to heavy use of MCWalkerConfiguration in those classes' API's. Often that whole mess is being passed to just get access to a few members in the inherited name space. But I'm defering it as much as possible. My plan is a max speed refactor into new method functions that don't rely on DMCUpdate or MCWalkerConfiguration. |
Is the default walker count handling consistent with the old DMC drivers? |
Yes, but I think and A/B unit test is still in order. |
In the interest of development velocity and real consequential deadlines this needs to get merged. If no one comments within the hour that they are looking at this I will merge the PR ahead of tonight's nightlies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Walker count behavior to be checked in future.
(Mark reports no comments) |
First installment of DMCBatched driver. Much the same pattern as the VMCBatched driver. Unit tests to basic instantiation. Does not appear to break existing production code. Debuggin in advanceWalkers.