Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified driver dmc batched #1947

Merged
merged 9 commits into from
Sep 27, 2019

Conversation

PDoakORNL
Copy link
Contributor

First installment of DMCBatched driver. Much the same pattern as the VMCBatched driver. Unit tests to basic instantiation. Does not appear to break existing production code. Debuggin in advanceWalkers.

@PDoakORNL
Copy link
Contributor Author

This is a good place to stop this PR as the next step is refactoring the branch engine and walker controllers which will be quite involved.

@prckent prckent changed the title [WIP] Unified driver dmc batched Unified driver dmc batched Sep 27, 2019
@prckent
Copy link
Contributor

prckent commented Sep 27, 2019

Can you ("we") defer updating the branch engine and walker controllers or is this required to get DMC batched working and estimate a FOM + throughput vs system size?

@PDoakORNL
Copy link
Contributor Author

PDoakORNL commented Sep 27, 2019

Can't be completely avoided due to heavy use of MCWalkerConfiguration in those classes' API's. Often that whole mess is being passed to just get access to a few members in the inherited name space.

But I'm defering it as much as possible. My plan is a max speed refactor into new method functions that don't rely on DMCUpdate or MCWalkerConfiguration.

@prckent
Copy link
Contributor

prckent commented Sep 27, 2019

Is the default walker count handling consistent with the old DMC drivers?

@jtkrogel jtkrogel mentioned this pull request Sep 27, 2019
@PDoakORNL
Copy link
Contributor Author

Yes, but I think and A/B unit test is still in order.

@prckent
Copy link
Contributor

prckent commented Sep 27, 2019

In the interest of development velocity and real consequential deadlines this needs to get merged. If no one comments within the hour that they are looking at this I will merge the PR ahead of tonight's nightlies.

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walker count behavior to be checked in future.

@prckent
Copy link
Contributor

prckent commented Sep 27, 2019

(Mark reports no comments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants