-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dense hamiltonian #2131
Merged
Merged
Add dense hamiltonian #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting for Alfredo's fix
…s from closed wfn if nup==ndoen
Can one of the admins verify this patch? |
fdmalone
commented
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful feature. Still in experimental phase, documentation and tests are coming in future (See #1061).
mmorale3
approved these changes
Dec 6, 2019
mmorale3
approved these changes
Dec 6, 2019
mmorale3
approved these changes
Dec 6, 2019
Okay to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dense implementation of factorised ERI (3-index) tensor for real hamiltonians. Avoids O(N^2M^2) memory overhead of storing half-rotated (ik|jl) used in the sparse code at a slightly increased computational cost. Ideal for larger molecules where sparsity in ERI tensor in MO basis is typically small. Works on GPU.