Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Space Warp Transformation for ZVZB Forces #2828

Merged
merged 25 commits into from
Jan 4, 2021

Conversation

rcclay
Copy link
Contributor

@rcclay rcclay commented Dec 24, 2020

Proposed changes

This implements a preliminary reference version of the space-warp transformation for ZVZB force estimators, given in https://doi.org/10.1063/1.3516208. Currently, Grad_i(E_L) w.r.t. electron coordinates is handled through finite differences, but replacement with analytic derivatives should reasonably occur within the current infrastructure.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Local intel Xeon server.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed.
  • No. Documentation has been added (if appropriate)

@rcclay rcclay requested a review from ye-luo December 24, 2020 02:49
Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clang-format the modified source code will also be helpful.

src/QMCHamiltonians/ACForce.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/ACForce.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/ACForce.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/OperatorBase.h Show resolved Hide resolved
src/QMCHamiltonians/OperatorBase.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/ACForce.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Outdated Show resolved Hide resolved
@rcclay
Copy link
Contributor Author

rcclay commented Jan 4, 2021

@ye-luo OK. Short of the making ions "const" issue and the default behavior of evaluateDeterministic, I believe I have addressed all your concerns.

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping with the code quality improvements. Only a few minor issues left.

src/QMCHamiltonians/OperatorBase.cpp Outdated Show resolved Hide resolved
src/QMCHamiltonians/OperatorBase.h Show resolved Hide resolved
src/QMCHamiltonians/NonLocalECPotential.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/QMCHamiltonian.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Outdated Show resolved Hide resolved
src/QMCHamiltonians/SpaceWarpTransformation.h Show resolved Hide resolved
@ye-luo ye-luo merged commit 4653d6e into QMCPACK:develop Jan 4, 2021
@rcclay rcclay deleted the space_warp_finite_diff branch January 4, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants