Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Resource lock nexus examples #3585

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Nov 3, 2021

Proposed changes

Speculative update to serialize nexus example tests and avoid potential race condition. Result should be no nexus examples sporadically failing on cdash. Only the example tests are serialized so the effect on overall test runtime is minimal.

What type(s) of changes does this code introduce?

  • Bugfix
  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@ye-luo ye-luo requested a review from jtkrogel November 3, 2021 18:13
@prckent prckent changed the title Resource lock nexus examples Nexus: Resource lock nexus examples Nov 3, 2021
Copy link
Contributor

@jtkrogel jtkrogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should capture only the user example tests.

@ye-luo
Copy link
Contributor

ye-luo commented Nov 3, 2021

Test this please

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will be all what we need.

@ye-luo ye-luo enabled auto-merge November 3, 2021 18:53
@ye-luo ye-luo merged commit 8876779 into QMCPACK:develop Nov 3, 2021
@prckent prckent deleted the reslock branch August 19, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants