Raise Intel classic compiler minimum version to 19.1. #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prckent
approved these changes
Jan 21, 2022
|
Start testing in-house |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The 19.0.x series (tested 19.0.5) failed in compiling ppcovert due to multi.
Raise compiler minimum version to 19.1.
https://www.intel.com/content/www/us/en/developer/articles/news/c17-features-supported-by-c-compiler.html
Shows 19.1 to fully complete C++17 implementation.
19.0.x started in 2018.
19.1.0 was released in Dec 2019, even already out of two year window.
I think 19.1.x should have been available in most places.
Hence it is safe to raise the minimum.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
bora
Checklist