Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HDF5 1.10 API #4352

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Use HDF5 1.10 API #4352

merged 5 commits into from
Dec 1, 2022

Conversation

quantumsteve
Copy link
Contributor

@quantumsteve quantumsteve commented Dec 1, 2022

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

Move QMCPACK to use the HDF5 1.10 API, released in 2016. 1.10 is available starting in Ubuntu 18.04 and RHEL 8 The 1.8 and 1.12 branches have their final patch releases in January 2023, so 1.10 seems to be the sweet spot.

I think this flag in 1.8 will let us use a longer std::string instead of std::vector<std::string> in ObservableHelper.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes

Does this introduce a breaking change?

  • No (might if we use HDF5 1.8+ features in hdf5 output)

What systems has this change been tested on?

my laptop, Ubuntu 20.04

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • Yes/No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • Yes/No. Documentation has been added (if appropriate)

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@prckent
Copy link
Contributor

prckent commented Dec 1, 2022

Following our 2 year rule, it is more than timely to require 1.10

Please also update https://github.com/QMCPACK/qmcpack/blob/develop/README.md

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@ye-luo ye-luo enabled auto-merge December 1, 2022 20:47
@ye-luo
Copy link
Contributor

ye-luo commented Dec 1, 2022

Test this please

@ye-luo ye-luo merged commit 3c3b92c into QMCPACK:develop Dec 1, 2022
@quantumsteve quantumsteve deleted the hdf5_version branch December 2, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants