Repository navigation
Restore old interop scheme using level_zero. - #4382
Merged
Merged
Conversation
Contributor
Author
|
Test this please |
PDoakORNL
approved these changes
Jan 5, 2023
PDoakORNL
left a comment
PDoakORNL
left a comment
Contributor
There was a problem hiding this comment.
We can only leverage the performance portability from openmp as much as is usable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Using OpenMP interop to directly create SYCL queue has a lot of limitations. Revert to the old way exposing only the Level0 device and context object.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
sunspot
Checklist