Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old interop scheme using level_zero. #4382

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 5, 2023

Proposed changes

Using OpenMP interop to directly create SYCL queue has a lot of limitations. Revert to the old way exposing only the Level0 device and context object.

What type(s) of changes does this code introduce?

  • Other (please describe):

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

sunspot

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 5, 2023

Test this please

Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only leverage the performance portability from openmp as much as is usable.

@PDoakORNL PDoakORNL merged commit 2b8422b into QMCPACK:develop Jan 5, 2023
@ye-luo ye-luo deleted the sycl-interop branch January 5, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants