Print coordinates when NaN is detected - #4401
Merged
Merged
Conversation
prckent
reviewed
Jan 19, 2023
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Have you been able to trigger this?
Contributor
Author
Only tested -"-vebose=debug". the print routine behaves as expected. Didn't have a way to directly trigger NaN. |
prckent
approved these changes
Jan 19, 2023
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rename expand ParticleSet::get to print and support particle count limit.
When NaN is detected, print all particle coordinates.
Also
--verbosity=debugnow prints all particle coordinates.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
laptop
Checklist