Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grid dim bug for eval_multi_multi_UBspline_3d_c_vgl_kernel #4421

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

pwang234
Copy link
Contributor

Proposed changes

This PR switches the GridDim.x and GridDim.y for eval_multi_multi_UBspline_3d_c_vgl_kernel to fix the issue that "num" can be larger than 65535, which is the maximum GridDim.y allowed in CUDA.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

A100.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor

prckent commented Jan 27, 2023

Test this please

@ye-luo
Copy link
Contributor

ye-luo commented Jan 27, 2023

Test this please

@ye-luo ye-luo enabled auto-merge January 27, 2023 20:52
@ye-luo ye-luo merged commit c101a9f into QMCPACK:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants