Add Pathak-Wagner Regularizer to ACForce - #4477
Merged
Merged
Conversation
ye-luo
reviewed
Feb 22, 2023
ye-luo
reviewed
Feb 22, 2023
Contributor
|
Test this please |
ye-luo
approved these changes
Feb 22, 2023
ye-luo
approved these changes
Feb 22, 2023
ye-luo
enabled auto-merge
February 22, 2023 23:00
prckent
reviewed
Feb 22, 2023
| regvalue = 1.0; | ||
| else | ||
| { | ||
| //There's a discrepancy between AIP Advances 10, 085213 (2020) and arXiv:2002.01434 for polynomial. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
This adds the Pathak-Wagner regularizer to all ACForce components, thus allowing the user to mitigate the formal infinite variance problems of this estimator. Access to this feature is done by specifying
epsilon=[Real > 0]in the ACForce XML section.What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Intel Xeon, RHEL7, Real and Complex builds.
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.