-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated plot method #308
Updated plot method #308
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 88.15% 87.79% -0.37%
==========================================
Files 89 89
Lines 4281 4300 +19
==========================================
+ Hits 3774 3775 +1
- Misses 507 525 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the abstract method called plot. I am pretty sure everything is correct, however I wrote a lot of documentation for the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Baronlegend27 This is a good start, the documentation for the method looks nice, I left some suggestions in this review. You still need to implement the method. This is not an abstract method but rather a method in the abstract class. Any subclass will inherit this plot
method so you do not need to rewrite this method for every discrete distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better! Left a few more suggestions on how to improve the method.
You may also allow a user to pass in an ax
argument which defaults to None
. If an ax
is passed in, you may just use that one to make the scatter plot on. If ax is None
then you can create the fig,ax
for the user.
Add some commands to pretty up the plot e.g. ones that set the aspect ratio, axis labels, axis ticks, axis limits
Updated the plot method