Reduce the number of initially needed packages for the Installer #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philross
force-pushed
the
reduceInitialImports
branch
from
6502667
to
2d6c6e8
Compare
Marvmann
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
"python src/main.py env -- configure myenv" runs with the three remaining required packages. Every functionality seems to work as before. The text in the installer section of the readme and tutorial might need to be improved at some point in the future. I will open an issue with low priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code a bit to reduce the number of initially needed packages to run the Installer.