Reduce number of collect calls #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeiakimov
approved these changes
Oct 6, 2021
cugni
requested changes
Oct 21, 2021
There was a problem hiding this comment.
I see that we still don't have a clear path between when and where we call collects. Lazy val are not a solution, we should avoid it. We should clearly define which are transformation class, where no action is triggered (and that must be fully serializable), and action class, where we actually call collect or head or similar functions.
I'm working on a version that used the Dataset interface instead of the Seq one more profusely. If it works, we can analyze that.
cugni
approved these changes
Oct 21, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #14.
This is a workaround to reduce the number of collect calls on the commit log data. The optimal solution would be to process everything with DataFrame, but in order to build the structures for the search algorithm, it is necessary to load some information in the memory.