Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): new table player_groups for multi-job #365

Merged
merged 3 commits into from
Feb 16, 2024
Merged

feat(sql): new table player_groups for multi-job #365

merged 3 commits into from
Feb 16, 2024

Conversation

Manason
Copy link
Member

@Manason Manason commented Feb 15, 2024

  • Changed group tables to use varchar instead of enum. Would rather this be more flexible in case we want to add new enum values, don't need to modify the schema.
  • Add new table player_groups to map characters to group_grades. Foreign key constraints enforce that a grade must exist for a player to hold it

@Manason Manason merged commit f313981 into main Feb 16, 2024
4 checks passed
@Manason Manason deleted the player-groups-sql branch February 16, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solareon solareon solareon approved these changes

@FjamZoo FjamZoo FjamZoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manason @solareon @FjamZoo