feat: diagnostic comments #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manason
approved these changes
Sep 7, 2024
D4isDAVID
previously requested changes
Sep 7, 2024
D4isDAVID
reviewed
Sep 8, 2024
solareon
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NotificationPositionandNotificationTypealias to types.lua to satisfy diagnosticsOnce merged, Qbox-project/github-docs#17 will satisfy the last remaining
undefined-globaldiagnostic warnings.If any of these should actually be fixed instead of diagnostically dismissed, feel free to comment or add to this PR.
Checklist