Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: debug based on lib.print convar #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArturMichalak
Copy link
Contributor

@ArturMichalak ArturMichalak commented Jun 9, 2024

Description

https://github.com/overextended/ox_lib/blob/master/imports/print/shared.lua#L18

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your thought process behind using the print level convar instead of the existing debug one?

@ArturMichalak
Copy link
Contributor Author

In the future, several debug level information points can be added. lib.print uses this convars. If user enables debug mode prints, the cron logs will also be displayed.

@ArturMichalak ArturMichalak deleted the debug branch June 10, 2024 15:00
@ArturMichalak ArturMichalak restored the debug branch June 10, 2024 15:00
@ArturMichalak ArturMichalak reopened this Jun 10, 2024
@ArturMichalak ArturMichalak marked this pull request as draft June 10, 2024 15:08
@ArturMichalak ArturMichalak marked this pull request as ready for review June 10, 2024 15:09
@ArturMichalak
Copy link
Contributor Author

looking forward to response to the issuse
overextended/ox_lib#593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants