-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing Images via a reference method #22
Conversation
Looks good 😍, let me test it and I will let you know about it. @lukebrandonfarrell |
Thanks @jasimawan let me know, and I'll merge |
lgtm! Just minor changes, what you think of adding the below code to as a callback of the setState:
when an image with a different size is added, it does not calculate the image with the right sizes. |
Just checked it on simulator as well as on real device. Working perfectly. @lukebrandonfarrell |
@harbolaez Nice catch! 😮 I'll add your suggestion then merge |
b9edc91
to
8d682f0
Compare
Will be released in version 3.3.0 |
This PR adds the ability to easily replace images with a new reference method:
Here is a video demo of it in action:
Replace.Images.mov
@jasimawan @harbolaez since you both are working with this feature in your projects, let me know your thoughts !