Add grayContent #76
Merged
Add grayContent #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deps 已经还原 @gaodq |
gaodq
suggested changes
Jul 11, 2017
manager/src/php/qconf_manager.cc
Outdated
| std::vector<std::pair<std::string, std::string> >::iterator it; | ||
| array_init(return_value); | ||
|
|
||
| if(zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &gray_id, &$gray_id_len) == FAILURE) |
manager/src/php/qconf_manager.cc
Outdated
| if (QCONF_OK != qconfzk->zk_gray_get_content(std::string(gray_id, gray_id_len), nodes)) RETURN_LONG(QCONF_PHP_ERROR); | ||
| for (it = nodes.begin(); it != nodes.end(); ++it) | ||
| { | ||
| add_assoc_string(return_value,(*it).first.c_str(),(char *)(*it).second.c_str()); |
There was a problem hiding this comment.
我的错，docker环境出了问题，不严谨！
|
重新在php5和php7 环境下 测试通过 @gaodq ； 另外master 本地安装失败 QConf/deps/zookeeper/configure 的LIBTOOL的问题 |
|
感谢提交！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增了一个grayContent，通过灰度id返回，灰度结点的map； 另外发现在php 7.0.12 版本里 char * 这种字符串会报错，需要用zend_string; 其余的php7版本 又是正常的。