Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discussion about user's compute env from knitting docs #570

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

caleb-johnson
Copy link
Collaborator

Fixes #546

@caleb-johnson caleb-johnson added documentation Improvements or additions to documentation stable backport potential Suitable to be backported to most recent stable branch by Mergify labels Apr 29, 2024
@coveralls
Copy link

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8897298287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.495%

Totals Coverage Status
Change from base Build 8855819698: 0.0%
Covered Lines: 3498
Relevant Lines: 3663

💛 - Coveralls


The toolbox currently contains the following tools:
- Circuit Cutting [[1-6]](#references)


For a more detailed discussion on circuit cutting, check out our [technical guide](https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/explanation/index.html#overview-of-circuit-cutting).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're slowly moving toward this being a circuit cutting repo, so I think it's fine to slip this very nice document in on our main docs pages

This project is meant to evolve rapidly and, as such, does not follow `Qiskit's deprecation policy <https://github.com/Qiskit/qiskit/blob/main/DEPRECATION.md>`_. We may occasionally make breaking changes in order to improve the user experience. When possible, we will keep old interfaces and mark them as deprecated, as long as they can co-exist with the new ones. Each substantial improvement, breaking change, or deprecation will be documented in the :ref:`release notes`.
For a more detailed discussion on circuit cutting, check out our `technical guide <https://qiskit-extensions.github.io/circuit-knitting-toolbox/circuit_cutting/explanation/index.html#overview-of-circuit-cutting>`__.

This project is meant to evolve rapidly and, as such, does not follow `Qiskit's deprecation policy <https://github.com/Qiskit/qiskit/blob/main/DEPRECATION.md>`__. We may occasionally make breaking changes in order to improve the user experience. When possible, we will keep old interfaces and mark them as deprecated, as long as they can co-exist with the new ones. Each substantial improvement, breaking change, or deprecation will be documented in the :ref:`release notes`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an underscore to make the __ used elsewhere in this doc. It only had one underscore before (probably fine)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's fine except when it's not and breaks Sphinx. 😅. better to have two underscores everywhere when we think of it.

docs/index.rst Outdated Show resolved Hide resolved
garrison
garrison previously approved these changes Apr 30, 2024
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

If you accept my relative-link suggestion, I want one of us to actually test it before this gets merged. I am happy to do this. Other links in this form work (sphinx does the rst -> html map automatically).

Co-authored-by: Jim Garrison <garrison@ibm.com>
@caleb-johnson
Copy link
Collaborator Author

Thanks, this looks great.

If you accept my relative-link suggestion, I want one of us to actually test it before this gets merged. I am happy to do this. Other links in this form work (sphinx does the rst -> html map automatically).

Link's working in the CI artifact. Should be good to merge. Thanks

@caleb-johnson caleb-johnson merged commit e6a49dc into main Apr 30, 2024
11 checks passed
@caleb-johnson caleb-johnson deleted the agnstc-to-env branch April 30, 2024 15:24
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
* Remove discussion about user's compute env from knitting docs

* revert deletion in index.rat

* link to explanatory

* Add blurb to docs/index

* fix link

* Update docs/index.rst

Co-authored-by: Jim Garrison <garrison@ibm.com>

---------

Co-authored-by: Jim Garrison <garrison@ibm.com>
(cherry picked from commit e6a49dc)
garrison pushed a commit that referenced this pull request Apr 30, 2024
…571)

* Remove discussion about user's compute env from knitting docs

* revert deletion in index.rat

* link to explanatory

* Add blurb to docs/index

* fix link

* Update docs/index.rst

Co-authored-by: Jim Garrison <garrison@ibm.com>

---------

Co-authored-by: Jim Garrison <garrison@ibm.com>
(cherry picked from commit e6a49dc)

Co-authored-by: Caleb Johnson <calebj1524@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reword docs to focus less on end-user's compute environment
3 participants