Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass backend as positional argument to SamplerV2 for job mode #633

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Pass backend as positional argument to SamplerV2 for job mode #633

merged 2 commits into from
Jul 8, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Jul 8, 2024

This fixes a deprecation warning.

Fixes #632.

@garrison garrison added documentation Improvements or additions to documentation tests Related to tests stable backport potential Suitable to be backported to most recent stable branch by Mergify labels Jul 8, 2024
@coveralls
Copy link

coveralls commented Jul 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9847189901

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9840717351: 0.0%
Covered Lines: 2410
Relevant Lines: 2410
💛 - Coveralls

@garrison garrison marked this pull request as ready for review July 8, 2024 21:42
@garrison garrison merged commit 1ca5b0c into main Jul 8, 2024
11 checks passed
@garrison garrison deleted the fix-632 branch July 8, 2024 21:42
mergify bot pushed a commit that referenced this pull request Jul 8, 2024
@garrison @mergify
Pass backend as positional argument to SamplerV2 for job mode (#633)
2b4ea4d 
* Pass `backend` as positional argument to `SamplerV2` for job mode

This fixes a deprecation warning.

Fixes #632.

* black

(cherry picked from commit 1ca5b0c)
@mergify mergify bot mentioned this pull request Jul 8, 2024
Merged
garrison added a commit that referenced this pull request Jul 8, 2024
@mergify @garrison
Pass backend as positional argument to SamplerV2 for job mode (#633…
e8935fa 
…) (#634)

* Pass `backend` as positional argument to `SamplerV2` for job mode

This fixes a deprecation warning.

Fixes #632.

* black

(cherry picked from commit 1ca5b0c)

Co-authored-by: Jim Garrison <garrison@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation stable backport potential Suitable to be backported to most recent stable branch by Mergify tests Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning from SamplerV2(backend=backend)
2 participants
@garrison @coveralls