This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
add reusable workflow for cleanup #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
This was referenced Jan 11, 2022
abdonrd
reviewed
Jan 12, 2022
Comment on lines
38
to
44
| - name: GH deployment status (deactivate) | ||
| id: gh_deployment | ||
| uses: bobheadxi/deployments@v0.6.2 | ||
| with: | ||
| step: deactivate-env | ||
| token: ${{ github.token }} | ||
| env: ${{ env.APP_NAME }} |
There was a problem hiding this comment.
We should deactivate it?
Because we use the same env for all the PRs.
There was a problem hiding this comment.
It's a good question, in the code that I was preparing for this I had the next line:
https://github.com/Qiskit/gh-actions/blob/clean-up-workflow/.github/workflows/code-engine-clean-up.yml#L44
But I'm not sure about which will be the final result for this.
There was a problem hiding this comment.
A little update about the change that we needed to merge after checking that this was not working as expected: #11
We can discuss the decision about the naming.
abdonrd
reviewed
Jan 12, 2022
Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com>
abdonrd
approved these changes
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR creates a reusable workflow for cleaning up PR previews
Fixes: #9