-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LO circuit cuts optimizer #471
Conversation
4e73f2a
to
aa280e8
Compare
…ons/circuit-knitting-toolbox into LO-circuit-cuts-optimizer
…-Extensions/circuit-knitting-toolbox into LO-circuit-cuts-optimizer
Pull Request Test Coverage Report for Build 8482139047Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thoughts now on merging this PR, @garrison , @caleb-johnson ? |
I'll wait for you both to give the 👍 , and I'll give it one more pass before merging |
I think we're good to go, from my perspective. |
"""Test optimization parameters for being valid data types.""" | ||
|
||
with pytest.raises(ValueError): | ||
_ = OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid to even suggest this, but I think the following would have been sufficient. No need to change this since all the linters are happy.
_ = OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps) | |
OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps) |
Closing in favor of #520 |
Create a subpackage,
circuit_knitting.cutting.cut_finding
, for users to automatically find LO gate + wire cuts, given some cut criteria.