MPS::Improve the heuristics for choosing the algorithm in sample_measure #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… two algorithms. The heuristics were determined experimentally
merav-aharoni
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
chriseclectic
changed the title
chriseclectic
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrote sample_measure in MPS so that it chooses between two algorithms -
sample_measure_using_probabilitiesandsample_measure_using_apply_measure, depending on number of qubits, shots, and maximum bond dimension of the state.Closes #944
Details and comments
The new heuristics was obtained experimentally. The user can override the heuristics by setting their preferred algorithm as a backend option.
See issue #944.