Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable code coverage reports, add consolidated CI workflow #248

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

daka1510
Copy link
Collaborator

@daka1510 daka1510 commented Mar 2, 2022

based on latest updates in https://github.com/qiskit/qiskit-ibm-runtime

Summary

Details and comments

Prepare for first release. Use a consistent approach with https://github.com/Qiskit/qiskit-ibm-runtime.

@daka1510
Copy link
Collaborator Author

daka1510 commented Mar 2, 2022

See https://github.com/daka1510/qiskit-ibm-provider/actions/runs/1922585087 for sample workflow run. The CI checks fail at the moment because there is an unused import (introduced via https://github.com/Qiskit/qiskit-ibm-provider/pull/246/files). This will be fixed via #247. I do not want to fix it here as well to avoid merge conflicts.

@daka1510
Copy link
Collaborator Author

daka1510 commented Mar 3, 2022

@rathishcholarajan please ignore the CI lint failures. They are due to pylint-dev/pylint#3882 (i.e. Python 3.9 does not work with the back-level version of pylint that we use). I'll cover that via a follow-up PR (#250).

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan rathishcholarajan merged commit ee2121e into Qiskit:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants