Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct job version #1524

Merged
merged 13 commits into from
May 8, 2024
Merged

Return correct job version #1524

merged 13 commits into from
May 8, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 16, 2024

Summary

WIP, needs ntc issue 3938, iqp-api 1184

Need to confirm if we want to retrieve version from the job params, doing so will make retrieving jobs significantly more slow

Details and comments

Fixes #1471

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Mar 16, 2024
@coveralls
Copy link

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8990791568

Details

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 83.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/rest/runtime.py 0 1 0.0%
qiskit_ibm_runtime/qiskit_runtime_service.py 7 8 87.5%
Totals Coverage Status
Change from base Build 8990741841: -0.01%
Covered Lines: 6280
Relevant Lines: 7524

💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review April 24, 2024 17:09
@kt474 kt474 requested review from ptristan3 and jyu00 May 1, 2024 17:57
@kt474
Copy link
Member Author

kt474 commented May 1, 2024

This is ready for review - I tested on cloud but the IQP /jobs endpoint does not return job params, even if exclude_params is set to false (works correctly with /job).

Following up on server side (ntc-iqp-channel 497)

Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit edeb75b into Qiskit:main May 8, 2024
20 checks passed
@kt474 kt474 deleted the correct-job-version branch May 8, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service.job() doesn't know about job version
3 participants