Add refresh method to fake backends #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9455558491Details
💛 - Coveralls |
…fresh-fake-backend
Pull Request Test Coverage Report for Build 9500935091Details
💛 - Coveralls |
kt474
reviewed
Jun 13, 2024
kt474
reviewed
Jun 13, 2024
Pull Request Test Coverage Report for Build 9516500365Details
💛 - Coveralls |
kt474
added
the
Changelog: New Feature
kt474
approved these changes
Jun 18, 2024
kt474
reviewed
Jun 18, 2024
Pull Request Test Coverage Report for Build 9568678069Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jyu00
reviewed
Jun 18, 2024
| if real_props: | ||
| new_version = real_props.backend_version | ||
|
|
||
| if new_version > version: |
There was a problem hiding this comment.
Can we really rely on the version? I don't think it gets updated every time new calibration is pushed. And why even check the version if the server side data is already the freshest.
| logger.info("There are no available new updates for %s.", self.backend_name) | ||
|
|
||
| except Exception as ex: | ||
| logger.info("The refreshing of %s has failed: %s", self.backend_name, str(ex)) |
There was a problem hiding this comment.
This should raise an exception or at least a warning. Info level log doesn't get surfaced by default.
| "The backend %s has been updated from {version} to %s version.", | ||
| self.backend_name, | ||
| real_props.backend_version, | ||
| ) |
There was a problem hiding this comment.
This just updates the files but doesn't actually refresh the target if it's already built since it's cached.
Comment on lines
+186
to
+190
| old_backend = FakeSherbrooke() | ||
| with self.assertLogs("qiskit_ibm_runtime", level="INFO"): | ||
| old_backend.refresh(self.service) | ||
| new_backend = FakeSherbrooke() | ||
| self.assertGreaterEqual(old_backend.backend_version, new_backend.backend_version) |
There was a problem hiding this comment.
I don't quite understand this test. If FakeSherbrooke currently has version 1. The server data has version 2. If the refresh() code is not working correctly, both old_backend and new_backend would remain at version 1, and the test would still pass.
ptristan3
added a commit
to ptristan3/qiskit-ibm-runtime
that referenced
this pull request
Jun 26, 2024
kt474
added a commit
that referenced
this pull request
Jul 10, 2024
* improvements from #1740 * updated tests * updated refresh condition * style fixes * mypy warning * update name --------- Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Fixes #1707