Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the docstring of Batch #1761

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

SamFerracin
Copy link
Collaborator

Summary

The docstring of batch is incorrect. Additonaly, the example shown is trivial, as it shows how to open a batch mode to run a single circuit. This PR fixes both issues.

Details and comments

Fixes # 1696

@SamFerracin SamFerracin changed the title Fixing the docstring ofBatch Fixing the docstring of Batch Jun 19, 2024
@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9586226089

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.0%

Totals Coverage Status
Change from base Build 9584804898: 0.0%
Covered Lines: 6077
Relevant Lines: 7411

💛 - Coveralls

@SamFerracin SamFerracin requested a review from jyu00 June 19, 2024 18:25
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but otherwise LGTM!

qiskit_ibm_runtime/batch.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/batch.py Outdated Show resolved Hide resolved
SamFerracin and others added 2 commits June 20, 2024 17:47
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9604841596

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.0%

Totals Coverage Status
Change from base Build 9584804898: 0.0%
Covered Lines: 6077
Relevant Lines: 7411

💛 - Coveralls

@SamFerracin SamFerracin merged commit eea7df4 into Qiskit:main Jun 20, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9604987773

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.0%

Totals Coverage Status
Change from base Build 9601825612: 0.0%
Covered Lines: 6077
Relevant Lines: 7411

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants