Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jobs to use state instead of status #179

Merged
merged 31 commits into from
Mar 31, 2022
Merged

Update jobs to use state instead of status #179

merged 31 commits into from
Mar 31, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 2, 2022

Summary

Details and comments

Fixes #168

@kt474 kt474 changed the title [WIP] Update jobs to use state instead of status Update jobs to use state instead of status Mar 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1924551626

  • -3 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 56.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/runtime_job.py 5 8 62.5%
Totals Coverage Status
Change from base Build 1923436832: 0.04%
Covered Lines: 2050
Relevant Lines: 3608
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2068307995

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 70.503%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/runtime_job.py 18 19 94.74%
Totals Coverage Status
Change from base Build 2065439017: 1.3%
Covered Lines: 2101
Relevant Lines: 2980
💛 - Coveralls

daka1510
daka1510 requested changes Mar 3, 2022
View reviewed changes
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
test/unit/mock/fake_runtime_client.py Outdated Show resolved Hide resolved
daka1510
daka1510 requested changes Mar 8, 2022
View reviewed changes
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
@daka1510
Copy link
Collaborator

daka1510 commented Mar 8, 2022

@kt474 please rerequest a review after you made changes (or tag me know if you have objections). Otherwise I might miss your review request :).

@kt474 kt474 requested a review from daka1510 March 11, 2022 04:59
daka1510
daka1510 requested changes Mar 11, 2022
View reviewed changes
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
test/unit/mock/fake_runtime_client.py Outdated Show resolved Hide resolved
@kt474 kt474 requested a review from daka1510 March 14, 2022 02:12
daka1510
daka1510 requested changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up, @kt474. Three minor remarks/questions. Other than that it looks good.

qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/runtime_job.py Show resolved Hide resolved
@kt474 kt474 requested a review from daka1510 March 14, 2022 22:12
daka1510
daka1510 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rathishcholarajan
rathishcholarajan requested changes Mar 29, 2022
View reviewed changes
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
@rathishcholarajan
Copy link
Member

@kt474 Could you please check the integration test failures in your fork?

@kt474
Copy link
Member Author

kt474 commented Mar 31, 2022

I believe it was just an intermittent fail - passing now here

@rathishcholarajan
Copy link
Member

I believe it was just an intermittent fail - passing now here

Thanks how about cloud integration tests? https://github.com/kt474/qiskit-ibm-runtime/runs/5760661798?check_suite_focus=true

@kt474
Copy link
Member Author

kt474 commented Mar 31, 2022

I believe it was just an intermittent fail - passing now here

Thanks how about cloud integration tests? https://github.com/kt474/qiskit-ibm-runtime/runs/5760661798?check_suite_focus=true

Was using the wrong cloud token, all passing now
https://github.com/kt474/qiskit-ibm-runtime/runs/5764090893?check_suite_focus=true

@rathishcholarajan rathishcholarajan merged commit 633db4e into Qiskit:main Mar 31, 2022
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
@renier
Add prototype tag to non-primitives (Qiskit#179)
187ae68
@kt474 kt474 deleted the job-state-field branch July 13, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daka1510 daka1510 daka1510 approved these changes

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using state object instead of status string
4 participants
@kt474 @coveralls @daka1510 @rathishcholarajan