Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_execution_time to service.run #353

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Add max_execution_time to service.run #353

merged 5 commits into from
Jun 7, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 6, 2022

Summary

Details and comments

Fixes #351

@coveralls
Copy link

coveralls commented Jun 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2456369775

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 66.285%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/rest/runtime.py 0 3 0.0%
Totals Coverage Status
Change from base Build 2448559224: 0.06%
Covered Lines: 2664
Relevant Lines: 4019
💛 - Coveralls

@kt474 kt474 changed the title [WIP] Add max_execution_time to service.run Add max_execution_time to service.run Jun 7, 2022
@kt474
Copy link
Member Author

kt474 commented Jun 7, 2022

I don't think unit tests make sense here so I didn't add them - let me know if you think they are necessary

rathishcholarajan
rathishcholarajan approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kt474! Left some suggestions which I'll merge...

qiskit_ibm_runtime/qiskit_runtime_service.py Outdated Show resolved Hide resolved
releasenotes/notes/max-execution-time-ecdb69210afe3d89.yaml Show resolved Hide resolved
releasenotes/notes/max-execution-time-ecdb69210afe3d89.yaml Outdated Show resolved Hide resolved
@rathishcholarajan rathishcholarajan merged commit d199b83 into Qiskit:main Jun 7, 2022
@rathishcholarajan rathishcholarajan added the Changelog: New Feature Include in the Added section of the changelog label Jun 17, 2022
@rathishcholarajan rathishcholarajan added this to the 0.5.0 milestone Jun 20, 2022
@kt474 kt474 deleted the max-execution-time branch July 13, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

Assignees

@kt474 kt474

Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Add support for setting max_execution_time at job level
3 participants
@kt474 @coveralls @rathishcholarajan