Repository: project setup #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Woohoo! almost there! |
* Issue 201 | Repository: swagger / openapi schema * Issue 201 | Repository: swagger login/out pages * Issue 201 | Repository: private paths swagger
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
# Conflicts: # client/quantum_serverless/core/program.py # infrastructure/docker/README.md # infrastructure/helm/quantumserverless/values.yaml
psschwei
reviewed
Mar 10, 2023
There was a problem hiding this comment.
This is a minor nit, but could we include a README in the repository directory with basic usage instructions? (even something as simple as the same code from #112 ) I wanted to try out the repository, but realized I didn't know how to get started with it...
|
Ups! Good point @psschwei , totally agree. I will add it 👍 |
IceKhan13
approved these changes
Mar 14, 2023
|
Yes! Working on those things right now 😄 |
# Conflicts: # Makefile # client/quantum_serverless/core/constants.py
|
How I created the PR I can't review it officially but from my part is ready to merge too. I annotated some improvements anyway: |
pacomf
approved these changes
Mar 15, 2023
# Conflicts: # infrastructure/helm/quantumserverless/Chart.yaml # infrastructure/helm/quantumserverless/values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR pretends to include to
quantum-serverlesstherepositoryAPI project. Features included as MVP are:Details and comments
Fix #112