-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository: project setup #151
Conversation
Woohoo! almost there! |
* Issue 201 | Repository: swagger / openapi schema * Issue 201 | Repository: swagger login/out pages * Issue 201 | Repository: private paths swagger
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
# Conflicts: # client/quantum_serverless/core/program.py # infrastructure/docker/README.md # infrastructure/helm/quantumserverless/values.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor nit, but could we include a README in the repository directory with basic usage instructions? (even something as simple as the same code from #112 ) I wanted to try out the repository, but realized I didn't know how to get started with it...
Ups! Good point @psschwei , totally agree. I will add it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before jumping on enhancing repository more,I would say we need to merge this PR as it getting huge already :)
After readme and resolving conflict, ofc :)
Yes! Working on those things right now 😄 |
# Conflicts: # Makefile # client/quantum_serverless/core/constants.py
How I created the PR I can't review it officially but from my part is ready to merge too. I annotated some improvements anyway: |
# Conflicts: # infrastructure/helm/quantumserverless/Chart.yaml # infrastructure/helm/quantumserverless/values.yaml
Summary
This PR pretends to include to
quantum-serverless
therepository
API project. Features included as MVP are:Details and comments
Fix #112