Fix VQD's optimal_values
#10279
Merged
Fix VQD's optimal_values
#10279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
And a bug fix release note |
Pull Request Test Coverage Report for Build 5289745616
💛 - Coveralls |
This reverts commit 5000d2f.
woodsp-ibm
reviewed
Jun 15, 2023
| @@ -200,6 +200,24 @@ def store_intermediate_result(eval_count, parameters, mean, metadata, step): | |||
| np.testing.assert_array_almost_equal(history["mean"], ref_mean, decimal=2) | |||
| np.testing.assert_array_almost_equal(history["step"], ref_step, decimal=0) | |||
|
|
|||
| @data(H2_PAULI, H2_OP, H2_SPARSE_PAULI) | |||
| def test_optimal_values(self, op): | |||
| """Test running same VQD twice to re-use optimizer, then switch optimizer""" | |||
There was a problem hiding this comment.
The description here seems to be a copy/paste from the following test, but...
...I guess the check for this field could have been added as a subtest under the test_basic_operator above that seems to have subtests for a bunch of the result fields, rather than a new test which has to run the VQD computation again.
There was a problem hiding this comment.
yes, you're totally right, I overlooked that. Fixed in bfa1bac
woodsp-ibm
added
stable backport potential
woodsp-ibm
approved these changes
Jun 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ElePT
added a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Fix optimal values * Add unittest * Add reno * Update unittest * Revert "Update unittest" This reverts commit 225cd09e1ae08cd48f5196fd1d3a87a549f0164a. * Update test * Make test subtest
ElePT
added a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Fix optimal values * Add unittest * Add reno * Update unittest * Revert "Update unittest" This reverts commit 5000d2fb02e8126b376d9cd30d2862c202af2755. * Update test * Make test subtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10263
Details and comments
I think that there should be a unit test checking this, will add soon.