converters #1410
Merged
converters #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaygambetta
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
mtreinish,
nonhermitian and
taalexander
as code owners
ajavadia
reviewed
Dec 5, 2018
| @@ -81,7 +77,9 @@ def __str__(self): | |||
| return str(self.draw(output='text')) | |||
|
|
|||
| def __eq__(self, other): | |||
| return DAGCircuit.fromQuantumCircuit(self) == DAGCircuit.fromQuantumCircuit(other) | |||
| # TODO: removed the DAG from this function | |||
There was a problem hiding this comment.
to remind us that if we combine them to remove this conversion. If we decide to not combine them they can do this step without converting to dag and then a circuit that is the same has data = data not just that the dag are equivalent
| """ | ||
| # pylint: disable=unused-argument | ||
| # TODO: if arguments are really unused, consider changing the signature | ||
| # TODO: removed the DAG from this function |
There was a problem hiding this comment.
When i do issue #1145 that we dont go to a dag to make the qobj
ajavadia
approved these changes
Dec 5, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Adding qobj converters * Adding circuit_to_dag * Tests * Cleaning up * Adding changes * Adding more * Lint * Update test_circuit_operations.py * Cleaning up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the converters to a folder to remove them from the objects.