Add support to qobj_to_circuits for qobj without qasm #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
ajavadia
reviewed
Dec 5, 2018
ajavadia
reviewed
Dec 5, 2018
|
can we do this after #1410 |
This commit adds support to the helper function in qiskit.tools.qobj_to_circuits for creating circuits from a qobj without compiled qasm in the header. It does this by looping over the Qobj object to run the operations needed to construct the circuit objects directly instead of just parsing qasm. Fixes Qiskit#1407
mtreinish
force-pushed
the
qobj-to-circuits-no-qasm-support
branch
from
2fb0ce5
to
1345c3b
Compare
ajavadia
approved these changes
Dec 6, 2018
jaygambetta
approved these changes
Dec 6, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This commit adds support to the helper function in qiskit.tools.qobj_to_circuits for creating circuits from a qobj without compiled qasm in the header. It does this by looping over the Qobj object to run the operations needed to construct the circuit objects directly instead of just parsing qasm. Fixes Qiskit#1407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds support to the helper function in
qiskit.tools.qobj_to_circuits for creating circuits from a qobj without
compiled qasm in the header. It does this by looping over the Qobj
object to run the operations needed to construct the circuit objects
directly instead of just parsing qasm.
Details and comments
Fixes #1407