Fix bug in align_acquires #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore AcquireInstructions
|
Checked that it fixed the error I had before |
dcmckayibm
approved these changes
Oct 28, 2019
kdk
added a commit
to kdk/qiskit-terra
that referenced
this pull request
Dec 9, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…fore AcquireInstructions (Qiskit#3307)
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug in
align_acquires. Measurement pulses which were perfectly valid were causing an error to be raised. Measure stimulus pulses weren't being aligned with the Acquire pulses.Details and comments
This rescheduling pass doesn't support multiple measurements or pulses after measurements. Had to track which channels were acquired/measured at what times, and allow one acquire and one measure on each channel, both of which would get scheduled at the same time.