Add qargs property, __call__, method to set qargs to BaseOperators
#3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
requested review from
1ucian0,
ajavadia,
kdk and
mtreinish
as code owners
chriseclectic
changed the title
qarg property, __call__, and clone methods to BaseOperatorsqargs property, __call__, method to set qargs to BaseOperators
This property can be set using the __call__ method of the operator. Doing so makes a clone of the operator (doesn't copy underlying data), and can be used with compose/dot functions to automatically infer the qarg kwarg. This allows subsystem composition using binary operators (eg: `op @ x([0]) @ x([1])) To implement the clone method the default initialization for operators is changed so that it doesn't copy the input data if it is in the correct format.
chriseclectic
force-pushed
the
feature/operator-qargs
branch
from
9257cd8
to
de15033
Compare
This was referenced Feb 25, 2020
ewinston
approved these changes
Mar 2, 2020
kdk
approved these changes
Mar 3, 2020
chriseclectic
added
the
Changelog: New Feature
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…ators (Qiskit#3873) * Add qargs property and clone method to operators This property can be set using the __call__ method of the operator. Doing so makes a clone of the operator (doesn't copy underlying data), and can be used with compose/dot functions to automatically infer the qarg kwarg. This allows subsystem composition using binary operators (eg: `op @ x([0]) @ x([1])) To implement the clone method the default initialization for operators is changed so that it doesn't copy the input data if it is in the correct format. * add tests * Add release notes Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3872
Allow subsystem composition and dot using binary operators (eg:
op @ x([0]) @ x([1]))Details and comments
_qargsinternal attribute toBaseOperatorwhich is defaulted to None on construction.__call__method toBaseOperatorwhich allows setting a_qargsvalue by returning a shallow copy of the current object with_qargsset.qargsproperty toBaseOperatorwhich returns the value of_qargs.composeanddotmethods of all BaseOperator subclasses to use the input objectsqargsproperty if theqargskwarg is not set.__call__method.