Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of backend name in Result.__repr__ #5284

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Fix display of backend name in Result.__repr__ #5284

merged 4 commits into from
Oct 29, 2020

Conversation

firewall2142
Copy link
Contributor

@firewall2142 firewall2142 commented Oct 23, 2020 •
edited
Loading

Summary

Fixed #5283 , changed backend_version to backend_name in Result.__repr__

Details and comments

changed backend_version to backend_name in Result.__repr__

@firewall2142 firewall2142 requested a review from a team as a code owner October 23, 2020 20:56
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kdk kdk changed the title Fixed issue #5283 Fix display of backend name in Result.__repr__ Oct 26, 2020
kdk
kdk reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@kdk kdk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @firewall2142 . It looks like there is a test that needs to be updated:
https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=20640&view=logs&j=377f2c8d-8b6f-583f-e152-2ff025e2543a&t=28b3ff0d-9e76-5e94-89e9-eed7321a383e&l=6580

@1ucian0 1ucian0 added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Oct 26, 2020
@1ucian0
Copy link
Member

1ucian0 commented Oct 29, 2020

test fixed in f5f0cef

@1ucian0 1ucian0 added automerge stable backport potential The bug might be minimal and/or import enough to be port to stable labels Oct 29, 2020
@mergify mergify bot merged commit c8de447 into Qiskit:master Oct 29, 2020
@mergify mergify bot mentioned this pull request Oct 29, 2020
Merged
mergify bot pushed a commit that referenced this pull request Oct 29, 2020
@firewall2142
Fix display of backend name in Result.__repr__ (#5284)
dbdaa1a 
* Fixed issue #5283

* adjust test

Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c8de447)
mergify bot added a commit that referenced this pull request Oct 29, 2020
@mergify @firewall2142
Fix display of backend name in Result.__repr__ (#5284) (#5310)
2a95fc3 
* Fixed issue #5283

* adjust test

Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c8de447)

Co-authored-by: Ashish Barnawal <ashbrnwl.2000@gmail.com>
@prakharb10 prakharb10 mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdk kdk kdk left review comments

@1ucian0 1ucian0 1ucian0 approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Super easy fix: backend_version should be backend_name, Result.__repr__
4 participants
@firewall2142 @CLAassistant @1ucian0 @kdk