Fix improper handling of BindingsArray in SamplerPub.coerce() (#11913)

* Fix SamplerPub.coerce too

* Update releasenotes/notes/fix-pub-coerce-5d13700e15126421.yaml

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>

---------

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
(cherry picked from commit 4e0de54)

qiskit/primitives/containers/sampler_pub.py

@@ -121,7 +121,7 @@ def coerce(cls, pub: SamplerPubLike, shots: int | None = None) -> SamplerPub:
 
         if len(pub) > 1 and pub[1] is not None:
             values = pub[1]
-            if not isinstance(values, Mapping):
+            if not isinstance(values, (BindingsArray, Mapping)):
                 values = {tuple(circuit.parameters): values}
             parameter_values = BindingsArray.coerce(values)
         else:

releasenotes/notes/fix-pub-coerce-5d13700e15126421.yaml

@@ -0,0 +1,8 @@
+---
+
+fixes:
+  - |
+    Fixed a bug where ``qiskit.primitives.containers.estimator_pub.EstimatorPub.coerce()`` and
+    ``qiskit.primitives.containers.sampler_pub.SamplerPub.coerce()``
+    improperly handle the case where the parameter values are a ``BindingsArray`` instance, giving
+    rise to a ``ValueError`` whenever it is attempted.

test/python/primitives/containers/test_sampler_pub.py

@@ -333,3 +333,15 @@ def test_coerce_tuple_3_trivial_params_shots(self, shots):
             0,
             msg="incorrect num parameters for `parameter_values` property",
         )
+
+    def test_coerce_pub_with_exact_types(self):
+        """Test coercing a SamplerPub with exact types."""
+        params = (Parameter("a"), Parameter("b"))
+        circuit = QuantumCircuit(2)
+        circuit.rx(params[0], 0)
+        circuit.ry(params[1], 1)
+
+        params = BindingsArray(data={params: np.ones((10, 2))})
+        pub = SamplerPub.coerce((circuit, params))
+        self.assertIs(pub.circuit, circuit)
+        self.assertIs(pub.parameter_values, params)