Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply_operation_back API in dag should change to be consistent with add_qreg and add_creg #1202

Closed
1ucian0 opened this issue Nov 2, 2018 · 0 comments · Fixed by #1210
Closed

apply_operation_back API in dag should change to be consistent with add_qreg and add_creg #1202

1ucian0 opened this issue Nov 2, 2018 · 0 comments · Fixed by #1210
Assignees
@ajavadia
Labels
type: enhancement It's working, but needs polishing
Projects
Transpiler
Milestone
0.7

Comments

@1ucian0
Copy link
Member

1ucian0 commented Nov 2, 2018

Recently, the API for DAGCircuit.add_qreg and DAGCircuit.add_creg changed to be called with an object instead of a tuple (see #1189). apply_operation_back should also change in the same direction to be consistent.
@1ucian0 1ucian0 added the type: enhancement It's working, but needs polishing label Nov 2, 2018
@1ucian0 1ucian0 added this to the 0.7 milestone Nov 2, 2018
@1ucian0 1ucian0 added this to To do in Transpiler via automation Nov 2, 2018
@ajavadia ajavadia self-assigned this Nov 2, 2018
@ajavadia ajavadia mentioned this issue Nov 4, 2018
Merged
Transpiler automation moved this from To do to done Dec 1, 2018
amaloney added a commit to amaloney/qiskit that referenced this issue Mar 13, 2024
@amaloney
Update gate dictionary in two_local.py
3a21a27 
This commit removes the hard coded gate dictionary with the one
generated by the method `get_standard_gate_name_mapping`.

Resolves Qiskit#1202
amaloney added a commit to amaloney/qiskit that referenced this issue Apr 17, 2024
@amaloney
Update gate dictionary in two_local.py
63cb581 
This commit removes the hard coded gate dictionary with the one
generated by the method `get_standard_gate_name_mapping`.

Resolves Qiskit#1202
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
@amaloney @jakelishman
Update gate dictionary in two_local.py (#12009)
3d676d2 
* Update gate dictionary in `two_local.py`

This commit removes the hard coded gate dictionary with the one
generated by the method `get_standard_gate_name_mapping`.

Resolves #1202

* Release note

* fix typo

* Tweak release-note wording

* Add explicit test

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajavadia ajavadia

Labels
type: enhancement It's working, but needs polishing
Projects
Transpiler
  
done
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Refactor DAGCircuit and Unrollers ajavadia/qiskit
2 participants
@1ucian0 @ajavadia