-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gate dictionary in two_local.py
#12009
Update gate dictionary in two_local.py
#12009
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8727412052Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! Please could you add a bugfix or features_circuit note (whichever you think is more appropriate) just to comment that all of the standard-library gates are now supported as valid string gates?
rebased against main as well as added a release note |
releasenotes/notes/update-gate-dictionary-c0c017be67bb2f29.yaml
Outdated
Show resolved
Hide resolved
This commit removes the hard coded gate dictionary with the one generated by the method `get_standard_gate_name_mapping`. Resolves Qiskit#1202
0159043
to
ffd5d23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Sorry I dropped the re-review for quite a while there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to explain - I pushed up a tweak to the release note since I think this is either a feature or a bugfix but not both (I went "feature", since that seemed to be the way you'd gone preferentially as well) and to add a couple of additional Sphinx cross-references to it. Don't worry at all about that - we very frequently tweak release notes at the point of publishing a release anyway, just to make the "voice" a bit more consistent.
I also threw in a test case for the request in the issue you solved - it was my mistake I didn't think about that before, and I didn't want to send you off on another round when I already was super slow coming back to the review.
Thanks very much for the contribution!
Summary
This commit removes the hard coded gate dictionary with the one generated by the method
get_standard_gate_name_mapping
.Details and comments
Resolves #12002