Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pulse channel index validation #10476

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix Pulse channel index validation #10476

merged 3 commits into from
Jul 24, 2023

Conversation

TsafrirA
Copy link
Collaborator

@TsafrirA TsafrirA commented Jul 22, 2023 •
edited by jakelishman

Summary

Fix a bug in the validation of Pulse channel index.

Fix #10475

@TsafrirA TsafrirA requested review from a team, eggerdj and wshanks as code owners July 22, 2023 08:26
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@mtreinish mtreinish added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Jul 22, 2023
@coveralls
Copy link

coveralls commented Jul 22, 2023 •
edited

Pull Request Test Coverage Report for Build 5644058125

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 85.928%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/unitary.py 1 93.75%
crates/qasm2/src/lex.rs 3 91.65%
crates/qasm2/src/parse.rs 6 97.58%
Totals Coverage Status
Change from base Build 5631006520: 0.002%
Covered Lines: 73019
Relevant Lines: 84977
💛 - Coveralls

jakelishman
jakelishman reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has been around for a while now, so could you add a test and potentially a one-liner bug-fix release note?

jakelishman
jakelishman approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@jakelishman jakelishman added this to the 0.25.0 milestone Jul 24, 2023
@jakelishman
Copy link
Member

btw, if you want your PR to autoclose an issue on merge, there's specific words you have to use, with one issue per line. "Addresses" isn't one unfortunately, so I updated your top comment to "Fix", which is one of them.

@TsafrirA
Copy link
Collaborator Author

Thanks @jakelishman!

@jakelishman jakelishman added this pull request to the merge queue Jul 24, 2023
Merged via the queue into Qiskit:main with commit 802a735 Jul 24, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
@TsafrirA @mergify
Fix Pulse channel index validation (#10476)
ccfd8cd 
* Correct channel index validation

* Add tests and release note.

(cherry picked from commit 802a735)
@mergify mergify bot mentioned this pull request Jul 24, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2023
@mergify @TsafrirA
Fix Pulse channel index validation (#10476) (#10486)
a801345 
* Correct channel index validation

* Add tests and release note.

(cherry picked from commit 802a735)

Co-authored-by: TsafrirA <113579969+TsafrirA@users.noreply.github.com>
to24toro pushed a commit to to24toro/qiskit-terra that referenced this pull request Aug 3, 2023
@TsafrirA @to24toro
Fix Pulse channel index validation (Qiskit#10476)
7640dea 
* Correct channel index validation

* Add tests and release note.
@TsafrirA TsafrirA deleted the patch-1 branch October 18, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@wshanks wshanks Awaiting requested review from wshanks wshanks is a code owner

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Pulse's channel index validation fails
5 participants
@TsafrirA @qiskit-bot @coveralls @jakelishman @mtreinish