Fix multiple nested custom controlled gates in QPY #10537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a circuit contained multiple custom controlled gates that in turn had custom definitions, the QPY serialisation could fail to write out some of the inner instructions correctly. This led to an invalid QPY file that could not be read back.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5717882763
💛 - Coveralls |
mtreinish
approved these changes
Aug 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Fix multiple nested custom controlled gates in QPY When a circuit contained multiple custom controlled gates that in turn had custom definitions, the QPY serialisation could fail to write out some of the inner instructions correctly. This led to an invalid QPY file that could not be read back. * Remove local warning-suppression import (cherry picked from commit 06416d7)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Fix multiple nested custom controlled gates in QPY When a circuit contained multiple custom controlled gates that in turn had custom definitions, the QPY serialisation could fail to write out some of the inner instructions correctly. This led to an invalid QPY file that could not be read back. * Remove local warning-suppression import (cherry picked from commit 06416d7) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this pull request
Sep 7, 2023
* Fix multiple nested custom controlled gates in QPY When a circuit contained multiple custom controlled gates that in turn had custom definitions, the QPY serialisation could fail to write out some of the inner instructions correctly. This led to an invalid QPY file that could not be read back. * Remove local warning-suppression import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a circuit contained multiple custom controlled gates that in turn had custom definitions, the QPY serialisation could fail to write out some of the inner instructions correctly. This led to an invalid QPY file that could not be read back.
Details and comments
Fix #9746.