Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open circles drawing incorrectly in mpl drawer and up visual circuit tests to .9999 accuracy #10580

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

enavarro51
Copy link
Contributor

Summary

Fixes a problem where open circles were drawing incorrectly in mpl circuit drawer and ups the visual circuit tests to .9999 accuracy

Details and comments

A bug in the drawing of open circles for conditional gates was introduced in #10504. Circles would be drawn closed when the value was 0. The auto visual circuit tests did not detect this problem due to the accuracy being set at 99%. This also changes that accuracy to 99.99%.

@enavarro51 enavarro51 requested review from nonhermitian and a team as code owners August 7, 2023 20:41
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5789710694

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 87.262%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/circuit/matplotlib.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/qasm2/src/lex.rs 3 91.65%
Totals Coverage Status
Change from base Build 5787606820: 0.02%
Covered Lines: 74260
Relevant Lines: 85100

💛 - Coveralls

@mtreinish mtreinish added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization labels Aug 7, 2023
@mtreinish mtreinish added this to the 0.25.1 milestone Aug 7, 2023
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Edwin. Let's try the visual tests with 0.9999 fidelity comparisons for now; if CI proves to be too flaky at that level, we can see if we can come up with something a bit more robust.

@jakelishman jakelishman added this pull request to the merge queue Aug 10, 2023
@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Aug 10, 2023
Merged via the queue into Qiskit:main with commit 6a7d109 Aug 10, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 10, 2023
(cherry picked from commit 6a7d109)

Co-authored-by: Edwin Navarro <enavarro@comcast.net>
SamD-1998 pushed a commit to SamD-1998/qiskit-terra that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants