(WIP) Add Sampler V2 #11264
Closed
(WIP) Add Sampler V2 #11264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-imamichi
force-pushed
the
sampler-v2
branch
from
8e82ce8
to
8e6f300
Compare
Pull Request Test Coverage Report for Build 7456384737
💛 - Coveralls |
t-imamichi
force-pushed
the
sampler-v2
branch
2 times, most recently
from
45cbd4b
to
b81f658
Compare
t-imamichi
force-pushed
the
sampler-v2
branch
from
b81f658
to
dab7978
Compare
t-imamichi
force-pushed
the
sampler-v2
branch
from
c6ac6b0
to
daaa49e
Compare
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com> Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
t-imamichi
force-pushed
the
sampler-v2
branch
from
daaa49e
to
c85bbf6
Compare
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
t-imamichi
force-pushed
the
sampler-v2
branch
from
c85bbf6
to
8cfb779
Compare
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
This was referenced Jan 9, 2024
Merged
|
#11566 supersedes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up of #11227 and it will rebase onto main once #11227 is merged.
This PR introduces BaseSamplerV2 and a reference implementation
StatevectorSampler(tentative name) to realize the following RFCSTODOs
Note: I might do a force push for the time being.
Details and comments