Add V2 primitive container classes #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
priority: high
mod: primitives
chriseclectic
requested review from
ikkoham,
t-imamichi and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
ikkoham
reviewed
Jan 9, 2024
Merged
ihincks
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Thanks @chriseclectic and @ikkoham .
I left some minor comments all to do with docstrings.
There are a bunch of # (C) Copyright IBM 2023. that we might want to change to 2024. Otherwise, LGTM!
ihincks
previously approved these changes
Jan 9, 2024
|
Also as @ikkoham said, FWIW, "partially a self review" applies to me too, as I wrote bits and pieces of a couple of things. |
Merged
Pull Request Test Coverage Report for Build 7465264931
💛 - Coveralls |
Add required container classes for V2 primitive implementations. Separated out from 11227 to unblock other PRs Co-Authored-By: Ikko Hamamura <ikkoham@users.noreply.github.com> Co-Authored-By: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-Authored-By: Ian Hincks <2229105+ihincks@users.noreply.github.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
chriseclectic
force-pushed
the
primitives/containers
branch
from
c54b0d0
to
e9770db
Compare
ihincks
approved these changes
Jan 9, 2024
3 tasks
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* Add V2 primitive container classes Add required container classes for V2 primitive implementations. Separated out from 11227 to unblock other PRs Co-Authored-By: Ikko Hamamura <ikkoham@users.noreply.github.com> Co-Authored-By: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-Authored-By: Ian Hincks <2229105+ihincks@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update copyright to 2024 * Fix linting errors --------- Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Ian Hincks <2229105+ihincks@users.noreply.github.com> Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add required container classes for V2 primitive implementations. Separated out from 11227 to unblock other PRs
Summary
This separates the common V2 primitives container classes from #11227 so discussion and modifications to SamplerV2 and EstimatorV2 can be worked on without blocking each other.
Note that this PR does not initially change any code from the subset of files from #11227 other than fixings some typos in doc strings.
Details and comments
My proposal to streamline getting the V2 primitives merged, and make it easier for the runtime to implement its primitives is to break #11227 and #11264 up 5 PRs (dependencies shown via nesting) for