Deprecate qiskit/quantum_info/synthesis and move to qiskit/synthesis #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyGarion
added
the
Changelog: Deprecation
ShellyGarion
requested review from
alexanderivrii,
a team and
ikkoham
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7627549240
💛 - Coveralls |
ShellyGarion
changed the title
…/synthesis/one_qubit
|
Like the deprecation of |
Cryoris
reviewed
Jan 23, 2024
releasenotes/notes/deprecate-qinfo-synthesis-23abd8c34fc0f52e.yaml
Outdated
Show resolved
Hide resolved
|
|
||
| warnings.warn( | ||
| "The qiskit.quantum_info.synthesis module is deprecated since Qiskit 0.46.0." | ||
| "It will be removed in Qiskit 1.0 release.", |
There was a problem hiding this comment.
Suggested change
| "It will be removed in Qiskit 1.0 release.", | |
| "It will be removed in the Qiskit 1.0 release.", |
| cnot_rxx_decompose(plus_ry=True, plus_rxx=False), | ||
| cnot_rxx_decompose(plus_ry=False, plus_rxx=True), | ||
| cnot_rxx_decompose(plus_ry=False, plus_rxx=False), | ||
| _cnot_rxx_decompose(), |
There was a problem hiding this comment.
Now that this is a private method, do we still need to test it or is it tested enough in the context of the composer? If yes, I'd think we can skip testing this
Cryoris
added
the
Changelog: Removal
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
…11460) * remove deprecated code in clifford_decompose and cnotdihedral_decompose * move tests from test/python/quantum_info to test/python/synthesis * move the Quaternion class from quantum_info/synthesis to quantum_info * deprecate cnot_rxx_decompose, and move to an internal code in the equivalence_library * deprecate cnot_rxx_decompose * move qsd from qiskit/quantum_info/synthesis to qiskit/synthesis/unitary * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle cyclic imports in qsd * minor * update qsd docs * move one_qubit_decompose from qiskit/quantum_info/synthesis to qiskit/synthesis/one_qubit * move xx_decompose from qiskit/quantum_info/synthesis to qiskit/synthesis/two_qubits * handle cyclic imports * move two-qubit synthesis code from qiskit/quantum_info/synthesis to qiskit/synthesis/two_qubits * update qsd docs * minor * add release notes * updates following review * add disable cyclic import to rv.py * add deprecation warning in qiskit/quantum_info/__init__.py * fix links * improve qsd docs following review * update qsd after review * change pending deprecatrion to deprecation in ion_decompose * update release notes following review * update pending deprecation to deprecation * add test for a deprecation * add more tests for deprecations * add another test for deprecation * handle lint errors * minor fix following review * remove test for _cnot_rxx_decompose() private method (cherry picked from commit 8887f44) # Conflicts: # qiskit/synthesis/__init__.py # qiskit/transpiler/synthesis/qsd.py # test/benchmarks/random_circuit_hex.py
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
…(backport #11460) (#11635) * Deprecate qiskit/quantum_info/synthesis and move to qiskit/synthesis (#11460) * remove deprecated code in clifford_decompose and cnotdihedral_decompose * move tests from test/python/quantum_info to test/python/synthesis * move the Quaternion class from quantum_info/synthesis to quantum_info * deprecate cnot_rxx_decompose, and move to an internal code in the equivalence_library * deprecate cnot_rxx_decompose * move qsd from qiskit/quantum_info/synthesis to qiskit/synthesis/unitary * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle lint and docs errors in qsd * handle cyclic imports in qsd * minor * update qsd docs * move one_qubit_decompose from qiskit/quantum_info/synthesis to qiskit/synthesis/one_qubit * move xx_decompose from qiskit/quantum_info/synthesis to qiskit/synthesis/two_qubits * handle cyclic imports * move two-qubit synthesis code from qiskit/quantum_info/synthesis to qiskit/synthesis/two_qubits * update qsd docs * minor * add release notes * updates following review * add disable cyclic import to rv.py * add deprecation warning in qiskit/quantum_info/__init__.py * fix links * improve qsd docs following review * update qsd after review * change pending deprecatrion to deprecation in ion_decompose * update release notes following review * update pending deprecation to deprecation * add test for a deprecation * add more tests for deprecations * add another test for deprecation * handle lint errors * minor fix following review * remove test for _cnot_rxx_decompose() private method (cherry picked from commit 8887f44) # Conflicts: # qiskit/synthesis/__init__.py # qiskit/transpiler/synthesis/qsd.py # test/benchmarks/random_circuit_hex.py * fix merge conflicts * fix merge conflicts * minor fix * update release notes --------- Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> Co-authored-by: Shelly Garion <shelly@il.ibm.com>
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate
qiskit/quantum_info/synthesisand move toqiskit/synthesis:qsdtoqiskit/synthesis/unitaryOneQubitEulerDecomposertoqiskit/synthesis/one_qubitXXDecomposer,TwoQubitBasisDecomposerandtwo_qubit_cnot_decomposetoqiskit/synthesis/two_qubits(the latter function is removed from the docs, since it has no docstring)Except of the following:
decompose_cliffordanddecompose_cnotdihedralsince they have already been deprecated in a previous release.cnot_rxx_decomposeand use it as an internal function in theequivalence_library.Quaternionclass toquantum_info.Details and comments
After #11426 and this PR will be merged, it will be possible to close the following issues:
close #4311
close #4699
close #9667
partially handles #7986